Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify runtests.jl #531

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Simplify runtests.jl #531

merged 2 commits into from
Sep 11, 2023

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Sep 9, 2023 •
edited
Loading

and skip cpu tests when testing on gpu.

The diff for runtests.jl is probably difficult to understand, but basically now we have a single block of tests for each backend.

Another change is that now "AMDGPU" is part of the test environment and we don't call Pkg.develop("AMDGPU").

@ToucheSir
Copy link
Member

If this was any FluxML repo other than NNlib I'd immediately be on board, but historically we've relied on Buildkite to catch threading-related bugs in the conv kernels and elsewhere because the buildkite runners have more threads to work with. Accomodating that would be a good idea.

@ToucheSir
Copy link
Member

On a side note, should we try moving to https://github.com/JuliaTesting/ReTestItems.jl for parallel test running and possible future VS Code integration? I noticed GPUCompiler recently did.

@CarloLucibello CarloLucibello mentioned this pull request Sep 11, 2023
Open
@CarloLucibello
Copy link
Member Author

If this was any FluxML repo other than NNlib I'd immediately be on board, but historically we've relied on Buildkite to catch threading-related bugs in the conv kernels and elsewhere because the buildkite runners have more threads to work with. Accomodating that would be a good idea.

I've reinstated cpu tests on CUDA machine

@CarloLucibello CarloLucibello mentioned this pull request Sep 11, 2023
Merged
2 tasks
@CarloLucibello CarloLucibello merged commit 83df642 into master Sep 11, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarloLucibello @ToucheSir